This repository has been archived by the owner on Nov 26, 2019. It is now read-only.
Avoid calling representative_presenter for each child work on a parent show page #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t show page It results in three trips to Solr and is too expensive. To avoid it, we index the data we need directly on the work itself. This does seem to significantly improve performance, and is probably the cause of our last remaining perf problem crosses fingers. I separately PR'd the indexing changes to master. I did them here too, which might cause a conflict on merge, but since the GenericWorkIndexer changes paths between the branches, I was worried it might end up lost entirely and not properly merged without a conflcit, I'd rather a conflict so we make sure it winds up here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It results in three trips to Solr and is too expensive.
To avoid it, we index the data we need directly on the work itself.
This does seem to significantly improve performance, and is probably the cause of
our last remaining perf problem crosses fingers.
I separately PR'd the indexing changes to master. I did them here too, which
might cause a conflict on merge, but since the GenericWorkIndexer changes
paths between the branches, I was worried it might end up lost entirely
and not properly merged without a conflcit, I'd rather a conflict so
we make sure it winds up here.